Good advice particularly hubberjub, katastrophe & vroomery. The techniques katastrophe describes were what I learned a lot from working with a co-writer who was an ace with constructing harmonies. I find a piano or keyboard is a much better aid than a guitar for identifying intervals.
But no matter how your voice sounds, pitch-wise, tonally...it's about breath control & techniques.
Here's a link to a book/CD course that's very good. I got it for my daughter years ago on recommendation from her HS Choir teacher. Even though she's got a natural ear (pitch, harmony) developed from being immersed in music since she was about 4 yrs. old, singing in school & church choirs, etc., she wanted proper technique. And while she got that from her teacher at school, she wanted something she could practice with at her own pace, at home.
Seth Riggs Book & CD Singing Course
^^
AXES: Fender '81 The STRAT, '12 Standard Tele, '78 Musicmaster Bass, '13 CN-240SCE Thinline; Rickenbacker '82 360-12BWB; Epiphone '05 Casino, '08 John Lennon EJ-160E; Guild '70 D-40NT; Ovation '99 Celebrity CS-257; Yamaha '96 FG411CE-12; Washburn '05 M6SW Mando, '08 Oscar Schmidt OU250Bell Uke; Johnson '96 JR-200-SB Squareneck Reso; Hofner '07 Icon B-Bass; Ibanez '12 AR-325. AMPS: Tech 21 Trademark 10; Peavey ValveKing Royal 8; Fender Acoustonic 90, Passport Mini, Mini Tonemaster; Marshall MS-2 Micro Stack; Behringer BX-108 Thunderbird; Tom Scholz Rockman. PEDALS/FX: Boss ME-50; Yamaha EMP100; Stage DE-1; Samson C-Com 16 L.R. Baggs ParaAcoustic D.I; MXR EQ-10.